Commit be62b403 by xzyfer

Retry CLI specs that fail three times

For some reason our test fail due to timeouts on seemingly random
cli tests. This instability has been growing worse. I've spent the
better part of the last two days looking into the issue without a
resolution. I'm starting to think it's an artefact cause by the
virtualisation used in CI, potentially related to resources
starvation.

The specs that fail do so trying to spawn a child process. The
process never spawns eventually resulting in a timeout. This is why
@nschonni attempt at addressing this by increasing the timeout in

Since the spawn failure is random, and catastrophic the best solution
I can think of in the short-medium term is to instruct mocha to retry
failing tests individually a couple times.

I've scoped this behaviour to the cli specs because at the moment
we have some specs that are not reentrant.
parent b1744447
...@@ -11,6 +11,9 @@ var assert = require('assert'), ...@@ -11,6 +11,9 @@ var assert = require('assert'),
LIBSASS_VERSION = null; LIBSASS_VERSION = null;
describe('cli', function() { describe('cli', function() {
// For some reason we experience random timeout failures in CI
// due to spawn hanging/failing silently. See #1692.
this.retries(4);
before(function(done) { before(function(done) {
var bin = spawn(cli, ['-v']); var bin = spawn(cli, ['-v']);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment