Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
O
openzeppelin-contracts-upgradeable
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
俞永鹏
openzeppelin-contracts-upgradeable
Commits
c8188c0b
Commit
c8188c0b
authored
Aug 24, 2021
by
Francisco Giordano
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add additional isOperationReady check in TimelockController
(cherry picked from commit
cec4f2ef
)
parent
cec0800c
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
3 deletions
+8
-3
CHANGELOG.md
CHANGELOG.md
+4
-0
TimelockController.sol
contracts/access/TimelockController.sol
+4
-3
No files found.
CHANGELOG.md
View file @
c8188c0b
# Changelog
# Changelog
## 3.4.2
*
`TimelockController`
: Add additional isOperationReady check.
## 3.4.1 (2021-03-03)
## 3.4.1 (2021-03-03)
*
`ERC721`
: made
`_approve`
an internal function (was private).
*
`ERC721`
: made
`_approve`
an internal function (was private).
...
...
contracts/access/TimelockController.sol
View file @
c8188c0b
...
@@ -227,7 +227,7 @@ contract TimelockController is AccessControl {
...
@@ -227,7 +227,7 @@ contract TimelockController is AccessControl {
*/
*/
function execute(address target, uint256 value, bytes calldata data, bytes32 predecessor, bytes32 salt) public payable virtual onlyRole(EXECUTOR_ROLE) {
function execute(address target, uint256 value, bytes calldata data, bytes32 predecessor, bytes32 salt) public payable virtual onlyRole(EXECUTOR_ROLE) {
bytes32 id = hashOperation(target, value, data, predecessor, salt);
bytes32 id = hashOperation(target, value, data, predecessor, salt);
_beforeCall(predecessor);
_beforeCall(
id,
predecessor);
_call(id, 0, target, value, data);
_call(id, 0, target, value, data);
_afterCall(id);
_afterCall(id);
}
}
...
@@ -246,7 +246,7 @@ contract TimelockController is AccessControl {
...
@@ -246,7 +246,7 @@ contract TimelockController is AccessControl {
require(targets.length == datas.length, "TimelockController: length mismatch");
require(targets.length == datas.length, "TimelockController: length mismatch");
bytes32 id = hashOperationBatch(targets, values, datas, predecessor, salt);
bytes32 id = hashOperationBatch(targets, values, datas, predecessor, salt);
_beforeCall(predecessor);
_beforeCall(
id,
predecessor);
for (uint256 i = 0; i < targets.length; ++i) {
for (uint256 i = 0; i < targets.length; ++i) {
_call(id, i, targets[i], values[i], datas[i]);
_call(id, i, targets[i], values[i], datas[i]);
}
}
...
@@ -256,7 +256,8 @@ contract TimelockController is AccessControl {
...
@@ -256,7 +256,8 @@ contract TimelockController is AccessControl {
/**
/**
* @dev Checks before execution of an operation's calls.
* @dev Checks before execution of an operation's calls.
*/
*/
function _beforeCall(bytes32 predecessor) private view {
function _beforeCall(bytes32 id, bytes32 predecessor) private view {
require(isOperationReady(id), "TimelockController: operation is not ready");
require(predecessor == bytes32(0) || isOperationDone(predecessor), "TimelockController: missing dependency");
require(predecessor == bytes32(0) || isOperationDone(predecessor), "TimelockController: missing dependency");
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment