Reorder AccessControl event to emit after assignment (#2738)

eea37691 · Francisco Giordano · GitHub · 1db30378 · eea37691
Unverified Commit eea37691 authored Jun 24, 2021 by Francisco Giordano Committed by GitHub Jun 24, 2021
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletions

AccessControl.sol contracts/access/AccessControl.sol +2 -1

No files found.
--- a/contracts/access/AccessControl.sol
+++ b/contracts/access/AccessControl.sol
@@ -230,8 +230,9 @@ abstract contract AccessControl is Context, IAccessControl, ERC165 {
     * Emits a {RoleAdminChanged} event.
     */
    function _setRoleAdmin(bytes32 role, bytes32 adminRole) internal virtual {
-        emit RoleAdminChanged(role, getRoleAdmin(role), adminRole);
+        bytes32 previousAdminRole = getRoleAdmin(role);
        _roles[role].adminRole = adminRole;
+        emit RoleAdminChanged(role, previousAdminRole, adminRole);
    }

    function _grantRole(bytes32 role, address account) private {