Commit f28a1354 by Francisco Giordano Committed by Nicolás Venturo

remove unnecessary internal constant (#1297)

parent f12817e4
...@@ -13,6 +13,6 @@ contract ERC721Holder is IERC721Receiver { ...@@ -13,6 +13,6 @@ contract ERC721Holder is IERC721Receiver {
public public
returns(bytes4) returns(bytes4)
{ {
return ERC721_RECEIVED; return this.onERC721Received.selector;
} }
} }
...@@ -8,19 +8,13 @@ pragma solidity ^0.4.24; ...@@ -8,19 +8,13 @@ pragma solidity ^0.4.24;
*/ */
contract IERC721Receiver { contract IERC721Receiver {
/** /**
* @dev Magic value to be returned upon successful reception of an NFT
* Equals to `bytes4(keccak256("onERC721Received(address,address,uint256,bytes)"))`,
* which can be also obtained as `IERC721Receiver(0).onERC721Received.selector`
*/
bytes4 internal constant ERC721_RECEIVED = 0x150b7a02;
/**
* @notice Handle the receipt of an NFT * @notice Handle the receipt of an NFT
* @dev The ERC721 smart contract calls this function on the recipient * @dev The ERC721 smart contract calls this function on the recipient
* after a `safetransfer`. This function MAY throw to revert and reject the * after a `safeTransfer`. This function MUST return the function selector,
* transfer. Return of other than the magic value MUST result in the * otherwise the caller will revert the transaction. The selector to be
* transaction being reverted. * returned can be obtained as `this.onERC721Received.selector`. This
* Note: the contract address is always the message sender. * function MAY throw to revert and reject the transfer.
* Note: the ERC721 contract address is always the message sender.
* @param _operator The address which called `safeTransferFrom` function * @param _operator The address which called `safeTransferFrom` function
* @param _from The address which previously owned the token * @param _from The address which previously owned the token
* @param _tokenId The NFT identifier which is being transferred * @param _tokenId The NFT identifier which is being transferred
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment