Commit 4c5281d4 by Andrew Nesbitt

Merge pull request #302 from jhnns/update/nan

Updated nan to 1.0.0
parents a7c9d473 ee01701c
...@@ -26,10 +26,10 @@ char* CreateString(Local<Value> value) { ...@@ -26,10 +26,10 @@ char* CreateString(Local<Value> value) {
void ExtractOptions(Local<Value> optionsValue, void* cptr, sass_context_wrapper* ctx_w, bool isFile) { void ExtractOptions(Local<Value> optionsValue, void* cptr, sass_context_wrapper* ctx_w, bool isFile) {
int source_comments; int source_comments;
Local<Object> options = Local<Object>::Cast(optionsValue); Local<Object> options = optionsValue->ToObject();
if (ctx_w) { if (ctx_w) {
NanInitPersistent(Object, stats, Local<Object>::Cast(options->Get(NanSymbol("stats")))); NanAssignPersistent(ctx_w->stats, options->Get(NanSymbol("stats"))->ToObject());
// async (callback) style // async (callback) style
Local<Function> callback = Local<Function>::Cast(options->Get(NanSymbol("success"))); Local<Function> callback = Local<Function>::Cast(options->Get(NanSymbol("success")));
...@@ -39,7 +39,6 @@ void ExtractOptions(Local<Value> optionsValue, void* cptr, sass_context_wrapper* ...@@ -39,7 +39,6 @@ void ExtractOptions(Local<Value> optionsValue, void* cptr, sass_context_wrapper*
} else { } else {
ctx_w->ctx = (sass_context*) cptr; ctx_w->ctx = (sass_context*) cptr;
} }
ctx_w->stats = stats;
ctx_w->request.data = ctx_w; ctx_w->request.data = ctx_w;
ctx_w->callback = new NanCallback(callback); ctx_w->callback = new NanCallback(callback);
ctx_w->errorCallback = new NanCallback(errorCallback); ctx_w->errorCallback = new NanCallback(errorCallback);
...@@ -70,9 +69,9 @@ void FillStatsObj(Handle<Object> stats, Ctx ctx) { ...@@ -70,9 +69,9 @@ void FillStatsObj(Handle<Object> stats, Ctx ctx) {
int i; int i;
Handle<Array> arr; Handle<Array> arr;
arr = Array::New(ctx->num_included_files); arr = NanNew<Array>(ctx->num_included_files);
for (i = 0; i < ctx->num_included_files; i++) { for (i = 0; i < ctx->num_included_files; i++) {
arr->Set(i, String::New(ctx->included_files[i])); arr->Set(i, NanNew<String>(ctx->included_files[i]));
} }
(*stats)->Set(NanSymbol("includedFiles"), arr); (*stats)->Set(NanSymbol("includedFiles"), arr);
} }
...@@ -82,9 +81,9 @@ void FillStatsObj(Handle<Object> stats, sass_file_context* ctx) { ...@@ -82,9 +81,9 @@ void FillStatsObj(Handle<Object> stats, sass_file_context* ctx) {
FillStatsObj<sass_file_context*>(stats, ctx); FillStatsObj<sass_file_context*>(stats, ctx);
if (ctx->options.source_comments == SASS_SOURCE_COMMENTS_MAP) { if (ctx->options.source_comments == SASS_SOURCE_COMMENTS_MAP) {
source_map = String::New(ctx->source_map_string); source_map = NanNew<String>(ctx->source_map_string);
} else { } else {
source_map = Null(); source_map = NanNull();
} }
(*stats)->Set(NanSymbol("sourceMap"), source_map); (*stats)->Set(NanSymbol("sourceMap"), source_map);
} }
...@@ -94,29 +93,28 @@ void MakeCallback(uv_work_t* req) { ...@@ -94,29 +93,28 @@ void MakeCallback(uv_work_t* req) {
TryCatch try_catch; TryCatch try_catch;
sass_context_wrapper* ctx_w = static_cast<sass_context_wrapper*>(req->data); sass_context_wrapper* ctx_w = static_cast<sass_context_wrapper*>(req->data);
Handle<Value> val, err;
int error_status = ctx_w->ctx ? ctx_w->ctx->error_status : ctx_w->fctx->error_status; int error_status = ctx_w->ctx ? ctx_w->ctx->error_status : ctx_w->fctx->error_status;
if (ctx_w->ctx) { if (ctx_w->ctx) {
FillStatsObj(ctx_w->stats, ctx_w->ctx); FillStatsObj(NanNew(ctx_w->stats), ctx_w->ctx);
} else { } else {
FillStatsObj(ctx_w->stats, ctx_w->fctx); FillStatsObj(NanNew(ctx_w->stats), ctx_w->fctx);
} }
if (error_status == 0) { if (error_status == 0) {
// if no error, do callback(null, result) // if no error, do callback(null, result)
val = ctx_w->ctx ? NanNewLocal(String::New(ctx_w->ctx->output_string)) : NanNewLocal(String::New(ctx_w->fctx->output_string)); char* val = ctx_w->ctx ? ctx_w->ctx->output_string : ctx_w->fctx->output_string;
Local<Value> argv[] = { Local<Value> argv[] = {
NanNewLocal(val), NanNew<String>(val),
NanNewLocal(ctx_w->stats->Get(NanSymbol("sourceMap"))) NanNew(ctx_w->stats)->Get(NanSymbol("sourceMap"))
}; };
ctx_w->callback->Call(2, argv); ctx_w->callback->Call(2, argv);
} else { } else {
// if error, do callback(error) // if error, do callback(error)
err = ctx_w->ctx ? NanNewLocal(String::New(ctx_w->ctx->error_message)) : NanNewLocal(String::New(ctx_w->fctx->error_message)); char* err = ctx_w->ctx ? ctx_w->ctx->error_message : ctx_w->fctx->error_message;
Local<Value> argv[] = { Local<Value> argv[] = {
NanNewLocal(err), NanNew<String>(err),
NanNewLocal(Integer::New(error_status)) NanNew<Integer>(error_status)
}; };
ctx_w->errorCallback->Call(2, argv); ctx_w->errorCallback->Call(2, argv);
} }
...@@ -151,12 +149,12 @@ NAN_METHOD(RenderSync) { ...@@ -151,12 +149,12 @@ NAN_METHOD(RenderSync) {
FillStatsObj(options->Get(NanSymbol("stats"))->ToObject(), ctx); FillStatsObj(options->Get(NanSymbol("stats"))->ToObject(), ctx);
if (ctx->error_status == 0) { if (ctx->error_status == 0) {
Local<Value> output = NanNewLocal(String::New(ctx->output_string)); Local<String> output = NanNew<String>(ctx->output_string);
free_context(ctx); free_context(ctx);
NanReturnValue(output); NanReturnValue(output);
} }
Local<String> error = String::New(ctx->error_message); Local<String> error = NanNew<String>(ctx->error_message);
free_context(ctx); free_context(ctx);
NanThrowError(error); NanThrowError(error);
NanReturnUndefined(); NanReturnUndefined();
...@@ -186,12 +184,12 @@ NAN_METHOD(RenderFileSync) { ...@@ -186,12 +184,12 @@ NAN_METHOD(RenderFileSync) {
FillStatsObj(options->Get(NanSymbol("stats"))->ToObject(), ctx); FillStatsObj(options->Get(NanSymbol("stats"))->ToObject(), ctx);
if (ctx->error_status == 0) { if (ctx->error_status == 0) {
Local<Value> output = NanNewLocal(String::New(ctx->output_string)); Local<String> output = NanNew<String>(ctx->output_string);
free_file_context(ctx); free_file_context(ctx);
NanReturnValue(output); NanReturnValue(output);
} }
Local<String> error = String::New(ctx->error_message); Local<String> error = NanNew<String>(ctx->error_message);
free_file_context(ctx); free_file_context(ctx);
NanThrowError(error); NanThrowError(error);
NanReturnUndefined(); NanReturnUndefined();
......
...@@ -41,7 +41,7 @@ ...@@ -41,7 +41,7 @@
"chalk": "~0.4.0", "chalk": "~0.4.0",
"mkdirp": "~0.3.5", "mkdirp": "~0.3.5",
"mocha": "~1.18.2", "mocha": "~1.18.2",
"nan": "~0.8.0", "nan": "~1.0.0",
"node-watch": "~0.3.4", "node-watch": "~0.3.4",
"optimist": "~0.6.1", "optimist": "~0.6.1",
"shelljs": "~0.2.6", "shelljs": "~0.2.6",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment