Merge pull request #1733 from xzyfer/feat/poc-testing-install

Adding unit test coverage to install

scripts/install.js

@@ -9,7 +9,7 @@ var fs = require('fs'),
   sass = require('../lib/extensions'),
   request = require('request'),
   log = require('npmlog'),
-  pkg = require('../package.json');
+  userAgent = require('./util/useragent');
 
 /**
  * Download file, if succeeds save, if not delete
@@ -53,7 +53,7 @@ function download(url, dest, cb) {
     proxy: getProxy(),
     timeout: 60000,
     headers: {
-      'User-Agent': getUserAgent(),
+      'User-Agent': userAgent(),
     }
   };
 
@@ -95,18 +95,6 @@ function download(url, dest, cb) {
 }
 
 /**
- * A custom user agent use for binary downloads.
- *
- * @api private
- */
-function getUserAgent() {
-  return [
-    'node/', process.version, ' ',
-    'node-sass-installer/', pkg.version
-  ].join('');
-}
-
-/**
  * Determine local proxy settings
  *
  * @param {Object} options

scripts/util/useragent.js

+var pkg = require('../../package.json');
+
+/**
+ * A custom user agent use for binary downloads.
+ *
+ * @api private
+ */
+module.exports = function() {
+  return [
+    'node/', process.version, ' ',
+    'node-sass-installer/', pkg.version
+  ].join('');
+};

test/useragent.js

+var assert = require('assert'),
+  pkg = require('../package.json'),
+  ua = require('../scripts/util/useragent');
+
+describe('util', function() {
+  describe('useragent', function() {
+    it('should look as we expect', function() {
+      var reNode = 'node/' + process.version;
+      var reSass = 'node-sass-installer/' + pkg.version;
+      var reUA = new RegExp('^' + reNode + ' ' + reSass + '$');
+
+      assert.ok(reUA.test(ua()));
+    });
+  });
+});