- 01 Mar, 2015 4 commits
-
-
Adeel authored
-
* Pass along the original property names to binding so we don't have to disown the existing ones and add the new ones. * Although it is a delicate matter: //perfectionkills.com/understanding-delete/ avoiding delete where you can is better for JS optimizers IMO. (hint: it de-optimizes the whole object to change its internal "shape", which means delete single property from object literal comes with a perf. trade-off) PR URL: #727.
Adeel authored -
Removal of option hashed based success and error callbacks
Adeel Mujahid authored -
This change removes the object hash success/error callbacks in favor of node style callbacks. This includes README and test updates, including the removal of two tests that are now obsolete. This also updates the CLI code pathway to use the node style callback. BREAKING API CHANGE This removes the success/error option keys as ways to register callbacks into node-sass. Instead, a function should be passed as the second parameter for the asyncronous `render` call. It takes a standard node signature of `error, callback`.
Jakob Heuser authored
-
- 28 Feb, 2015 13 commits
-
-
Package: Removes unused pacakge 'object-assign'
Adeel Mujahid authored -
* Also moves cross-spawn under devDependencies.
Adeel authored -
Repo: Removes .npmignore, configures package.json
Adeel Mujahid authored -
Adeel authored
-
Code: Formats and fixes JSCS warnings
Adeel Mujahid authored -
* To avoid validating node_modules directory. PR URL: #723.
Adeel authored -
* Removes unused pacakge `shelljs`. * Fixes package.json validation issue reported by WE2013, based on njs package.json schema: > *The value property "repository" must be of type "Object", but was "sass/node-sass"* PR URL: #723.
Adeel authored -
Misc. improvements
Adeel Mujahid authored -
Adeel authored
-
* Adds instructions. * Removes obsolete info. This is for DRY'ing comments on repeating issues.
Adeel authored -
* Based on sindresorhus/meow#2. * Adds alias -v. * Improves info text; inspired by Less CLI. :) * Updates readme. PR URL: #717.
Adeel authored -
* Removes tests from publishing. #683 * Uses new strategy to validate binary after the download. * Moves mocha under dev-dependencies in package.json. * Truncates the forth portion from v8 version as discussed in #710. * Moves pangyp from dev to main dependencies in package.json. Issue URLs: #683 and #710. PR URL: #717.Adeel authored
-
- 27 Feb, 2015 2 commits
-
-
API: Retires non-standard image-path option.
Adeel Mujahid authored -
Adeel authored
-
- 25 Feb, 2015 2 commits
-
-
Issue URL: #702. PR URL: #704.
Adeel authored -
Adding a backwards compatible node-style callback
Adeel Mujahid authored
-
- 24 Feb, 2015 3 commits
-
-
While updating the readme, there was inconsistency between tabs and spaces this makes it all-spaces, which is in alignment with the JS standards for the project. (Plus, mixing the two is some horrible form of evil)
Jakob Heuser authored -
This is node-style callbacks for #676. This allows us to release the new callback style without introducing backwards incompatible changes (or making changes to the binary from 2.0.1). If a node style callback is provided, it will be used. For now, this stacks with the original `options.success` and `options.error`, although it can be trivially changed to an xor. To highlight the new interface, a separate `describe` was added to the tests which identifies the `{options}, cb` interface and tests it independently.Jakob Heuser authored -
CLI: Retires stdout option
Adeel Mujahid authored
-
- 23 Feb, 2015 2 commits
-
-
When no destination or output folder is provided, it will print the output to stdout. If the source-map option was set, it will print it as well. Issue URL: #669. PR URL: #701.
Adeel authored -
Build: Uses v8 version instead of runtime name.
Adeel Mujahid authored
-
- 22 Feb, 2015 1 commit
-
-
The new binary path format is: `<platform>-<arch>-<v8 version>/binding.node` Issue URL: #694. PR URL: #695.
Adeel authored
-
- 20 Feb, 2015 1 commit
-
-
Render options in callbacks as this.options
Adeel Mujahid authored
-
- 19 Feb, 2015 1 commit
-
-
This patch and tests introduces a context for all callbacks currently in node-sass. Right now, they run w/ an ambiguous context, making the `this` keyword not helpful to importer developers (and eventually custom function developers). This creates a context object, adds the render options to said context object, and then uses that context for importer, success, and error callbacks via `this.options`. By using a context instead of just `.call(options...)` there is a hook for later should we find additional environmental information is valuable to importer / custom function developers such as the node environment, node-sass version, etc.
Jakob Heuser authored
-
- 15 Feb, 2015 6 commits
-
-
Misc. Fixes
Adeel Mujahid authored -
Adeel authored
-
On Windows, process.execPath does not get resolved symlink path. This commit fixes the issue. Related Issue: iojs/io.js#851. PR URL: #668.
Adeel authored -
Adeel authored
-
Adeel authored
-
* Returns json-string error from LibSass as is. * Extends empty error object with parsed JSON. Note: The reason why NanError is not used because LibSass returns error as JSON string with message as member, so we would have to reparse and reassign the obj in that case. Issue URL: #675. PR URL: #668.
Adeel authored
-
- 12 Feb, 2015 5 commits
-
-
* Reason: njs v0.11 is not relavent any more. * Solution: Update to node v0.12 with which node-sass v2.0.1 is compatible OOTB.Adeel authored -
Code: Minor fixes.
Adeel Mujahid authored -
Adeel authored
-
xzyfer authored
-
xzyfer authored
-