1. 03 Oct, 2016 1 commit
    • POC for adding unit test coverage to install · b1188bc9
      The installer is getting more complicated. The core of it is a http
      request which makes testing it difficult/messy. Pulling out core
      logic into small util functions that we can unit test would give me
      much more confidence moving forward.
      
      I would prefer we don't export functions from scripts so people don't
      start relying on undocumented APIs. This is why I opted for helper
      utils but I'm not committed to them.
      xzyfer authored
  2. 13 Sep, 2016 4 commits
  3. 08 Sep, 2016 2 commits
  4. 07 Sep, 2016 3 commits
  5. 06 Sep, 2016 11 commits
  6. 04 Sep, 2016 11 commits
  7. 02 Sep, 2016 1 commit
  8. 01 Sep, 2016 4 commits
  9. 31 Aug, 2016 3 commits
    • Retry CLI specs that fail three times · be62b403
      For some reason our test fail due to timeouts on seemingly random
      cli tests. This instability has been growing worse. I've spent the
      better part of the last two days looking into the issue without a
      resolution. I'm starting to think it's an artefact cause by the
      virtualisation used in CI, potentially related to resources
      starvation.
      
      The specs that fail do so trying to spawn a child process. The
      process never spawns eventually resulting in a timeout. This is why
      @nschonni attempt at addressing this by increasing the timeout in
      
      Since the spawn failure is random, and catastrophic the best solution
      I can think of in the short-medium term is to instruct mocha to retry
      failing tests individually a couple times.
      
      I've scoped this behaviour to the cli specs because at the moment
      we have some specs that are not reentrant.
      xzyfer authored
    • Add a timeout to the binary fetch request (#1691) · 4dae69cc
      This PR adds a timeout to the binary fetch request as well as a
      useful error message.
      
      It came to light in #1690 that the download can block for a long time.
      
      ```
      npm info lifecycle node-sass@3.8.0~install: node-sass@3.8.0
      
      > node-sass@3.8.0 install /Usersproject-path/node_modules/node-sass
      > node scripts/install.js
      
      Build timed out (after 35 minutes). Marking the build as failed.
      ```
      
      We see a fair amount of hung installer issues that could be related
      to this. The error output will give us another data point in those
      cases.
      Michael Mifsud authored
    • Add a timeout to the binary fetch request · 1afce60a
      This PR adds a timeout to the binary fetch request as well as a
      useful error message.
      
      It came to light in #1690 that the download can block for a long time.
      
      ```
      npm info lifecycle node-sass@3.8.0~install: node-sass@3.8.0
      
      > node-sass@3.8.0 install /Usersproject-path/node_modules/node-sass
      > node scripts/install.js
      
      Build timed out (after 35 minutes). Marking the build as failed.
      ```
      
      We see a fair amount of hung installer issues that could be related
      to this. The error output will give us another data point in those
      cases.
      xzyfer authored