Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
O
openzeppelin-contracts-upgradeable
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
俞永鹏
openzeppelin-contracts-upgradeable
Commits
b99f49d3
Commit
b99f49d3
authored
Aug 24, 2021
by
Francisco Giordano
Browse files
Options
Browse Files
Download
Plain Diff
Merge remote-tracking branch 'vanilla/release-v4.3' into patched/release-v4.3
parents
e4e0729c
0ec7f4c2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
3 deletions
+8
-3
CHANGELOG.md
CHANGELOG.md
+4
-0
TimelockController.sol
contracts/governance/TimelockController.sol
+4
-3
No files found.
CHANGELOG.md
View file @
b99f49d3
# Changelog
## 4.3.1
*
`TimelockController`
: Add additional isOperationReady check.
## 4.3.0 (2021-08-17)
*
`ERC2771Context`
: use private variable from storage to store the forwarder address. Fixes issues where
`_msgSender()`
was not callable from constructors. (
[
#2754
](
https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2754
)
)
...
...
contracts/governance/TimelockController.sol
View file @
b99f49d3
...
...
@@ -268,7 +268,7 @@ contract TimelockController is AccessControl {
bytes32 salt
) public payable virtual onlyRoleOrOpenRole(EXECUTOR_ROLE) {
bytes32 id = hashOperation(target, value, data, predecessor, salt);
_beforeCall(predecessor);
_beforeCall(
id,
predecessor);
_call(id, 0, target, value, data);
_afterCall(id);
}
...
...
@@ -293,7 +293,7 @@ contract TimelockController is AccessControl {
require(targets.length == datas.length, "TimelockController: length mismatch");
bytes32 id = hashOperationBatch(targets, values, datas, predecessor, salt);
_beforeCall(predecessor);
_beforeCall(
id,
predecessor);
for (uint256 i = 0; i < targets.length; ++i) {
_call(id, i, targets[i], values[i], datas[i]);
}
...
...
@@ -303,7 +303,8 @@ contract TimelockController is AccessControl {
/**
* @dev Checks before execution of an operation's calls.
*/
function _beforeCall(bytes32 predecessor) private view {
function _beforeCall(bytes32 id, bytes32 predecessor) private view {
require(isOperationReady(id), "TimelockController: operation is not ready");
require(predecessor == bytes32(0) || isOperationDone(predecessor), "TimelockController: missing dependency");
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment