Commit e9068859 by Francisco Giordano Committed by GitHub

Merge pull request #448 from SylTi/fix/small-fixes

A bunch of small fixes
parents d3c5ce26 1203a247
...@@ -11,11 +11,23 @@ import '../lifecycle/Pausable.sol'; ...@@ -11,11 +11,23 @@ import '../lifecycle/Pausable.sol';
contract PausableToken is StandardToken, Pausable { contract PausableToken is StandardToken, Pausable {
function transfer(address _to, uint256 _value) whenNotPaused public returns (bool) { function transfer(address _to, uint256 _value) public whenNotPaused returns (bool) {
return super.transfer(_to, _value); return super.transfer(_to, _value);
} }
function transferFrom(address _from, address _to, uint256 _value) whenNotPaused public returns (bool) { function transferFrom(address _from, address _to, uint256 _value) public whenNotPaused returns (bool) {
return super.transferFrom(_from, _to, _value); return super.transferFrom(_from, _to, _value);
} }
function approve(address _spender, uint256 _value) public whenNotPaused returns (bool) {
return super.approve(_spender, _value);
}
function increaseApproval(address _spender, uint _addedValue) public whenNotPaused returns (bool success) {
return super.increaseApproval(_spender, _addedValue);
}
function decreaseApproval(address _spender, uint _subtractedValue) public whenNotPaused returns (bool success) {
return super.decreaseApproval(_spender, _subtractedValue);
}
} }
...@@ -26,7 +26,7 @@ contract StandardToken is ERC20, BasicToken { ...@@ -26,7 +26,7 @@ contract StandardToken is ERC20, BasicToken {
function transferFrom(address _from, address _to, uint256 _value) public returns (bool) { function transferFrom(address _from, address _to, uint256 _value) public returns (bool) {
require(_to != address(0)); require(_to != address(0));
var _allowance = allowed[_from][msg.sender]; uint256 _allowance = allowed[_from][msg.sender];
// Check is not needed because sub(_allowance, _value) will already throw if this condition is not met // Check is not needed because sub(_allowance, _value) will already throw if this condition is not met
// require (_value <= _allowance); // require (_value <= _allowance);
...@@ -49,7 +49,7 @@ contract StandardToken is ERC20, BasicToken { ...@@ -49,7 +49,7 @@ contract StandardToken is ERC20, BasicToken {
// allowance to zero by calling `approve(_spender, 0)` if it is not // allowance to zero by calling `approve(_spender, 0)` if it is not
// already 0 to mitigate the race condition described here: // already 0 to mitigate the race condition described here:
// https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729 // https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729
require((_value == 0) || (allowed[msg.sender][_spender] == 0)); // require((_value == 0) || (allowed[msg.sender][_spender] == 0));
allowed[msg.sender][_spender] = _value; allowed[msg.sender][_spender] = _value;
Approval(msg.sender, _spender, _value); Approval(msg.sender, _spender, _value);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment