Commits · 2c40ffa011bce21d2466aeb307cafb6ac460680b · 俞永鹏 / openzeppelin-contracts-upgradeable

20 Oct, 2018 25 commits

Improve encapsulation on ERC165 and update code style guide (#1379) · 2c40ffa0
```
* use prefix underscore for internal state variables

* make _supportedInterfaces private

(cherry picked from commit 03dfb296)
```
Mikhail Melnik authored Oct 13, 2018
2c40ffa0 Browse Files

First test helpers tests (#1369) · 10a5864f

* Removed unused advanceToBlock.

* Added advanceBlock tests.

* Fixed advanceToBlock tests.

* Added single argument tests.

* Finished inLogs tests.

* Fixed linter errors.

* Fixed linter errors.

(cherry picked from commit 9f822906)

authored Oct 10, 2018

10a5864f Browse Files

Fix typo in ARCHITECTURE.md (#1406) · 7ec60797
```
(cherry picked from commit eb92fd1f)
```
Nicolás Venturo authored Oct 10, 2018
7ec60797 Browse Files
Add a code style rule to make all state variables private (#1390) · 5e82a64a
```
(cherry picked from commit 076cb7de)
```
Leo Arias authored Oct 10, 2018
5e82a64a Browse Files

Non-constructor initialization removed (#1403) · 3266de1b

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1391

(cherry picked from commit da67e435)

authored Oct 10, 2018

3266de1b Browse Files

Replaced assertJump, assertRevert and expectThrow with shouldFail. (#1363) · 7cd0d5a4

* Replaced assertJump, assertRevert and expectThrow with shouldFail.

* Fixed linter errors.

* Fixed typo.

* Made the helpers async.

(cherry picked from commit b0da0fde)

authored Oct 09, 2018

7cd0d5a4 Browse Files

Improves Ownable events (#1397) · 620d5243

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1392

* event tests added

* constructor event added

(cherry picked from commit af42c39e)

authored Oct 09, 2018

620d5243 Browse Files

`this` is used in tests (#1380) · eae40c93

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1200

* suggested change

(cherry picked from commit b41b125c)

authored Oct 04, 2018

eae40c93 Browse Files

Replaces `amount` with `value` for consistency (#1378) · 109eba92
```
* fixes #1372

* done in ERC20Capped and ERC20Mintable

(cherry picked from commit fd4de776)
```
Aniket authored Oct 04, 2018
109eba92 Browse Files
Fixed test path. · 13fb1f66
```
(cherry picked from commit f4d6f404)
```
Nicolás Venturo authored Oct 02, 2018
13fb1f66 Browse Files
Created test utils directory · 2f3f0d3c
```
(cherry picked from commit 269981ee)
```
Nicolás Venturo authored Oct 02, 2018
2f3f0d3c Browse Files
Merged latestTime, increaseTime and duration into a time helper. (#1364) · 0678f672
```
(cherry picked from commit 34bc709b)
```
Nicolás Venturo authored Oct 02, 2018
0678f672 Browse Files

Fix/#1355 test helper to check balance difference (#1368) · b0393252

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* fixex #1355

* linting

* suggested changes

* Update BreakInvariantBounty.test.js

(cherry picked from commit 6ae041bc)

authored Oct 01, 2018

b0393252 Browse Files

Fix #1358 Test helper to send funds (#1367) · c25a1e36

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* fixes #1358

* linting done

* suggested changes

(cherry picked from commit fa1dfbd1)

authored Oct 01, 2018

c25a1e36 Browse Files

Dangling commas are now required. (#1359) · 598a0358
```
(cherry picked from commit a6889776)
```
Nicolás Venturo authored Sep 28, 2018
598a0358 Browse Files

Feature/use expect event in test logs assertions #1232 (#1343) · 39db4b4b

* Add BigNumber support to expectEvent/inLogs (#1026)

* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js

* Refactor expectEvent.inLogs function to use simple value number check

* Introduced should.be.bignumber method to compare BigNumber values

* Use expectEvent to test logs (#1232)

* Removed trailing space

(cherry picked from commit 536262f2)

authored Sep 27, 2018

39db4b4b Browse Files

Add BigNumber support to expectEvent/inLogs (#1026) (#1338) · a9af619c

* Add BigNumber support to expectEvent/inLogs (#1026)

* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js

* Refactor expectEvent.inLogs function to use simple value number check

* Introduced should.be.bignumber method to compare BigNumber values

* Destructure transaction object to extract logs field

(cherry picked from commit 947de54c)

authored Sep 26, 2018

a9af619c Browse Files

Removed BreakInvariantBounty. (#1424) · 62ed8e2f
```
(cherry picked from commit 9be0f100)
```
Nicolás Venturo authored Oct 16, 2018
62ed8e2f Browse Files
Turn off blank-lines Solium rule (#1284) · e7aa8ded
```
* turn off blank-lines rule

* remove triple newlines

(cherry picked from commit 9b371046)
```
Francisco Giordano authored Sep 19, 2018
e7aa8ded Browse Files

Add Mock suffix to variable names #1172 (#1324) · 49d2dd9e

* Add Mock suffix to variable names #1172

* Add Impl suffix to variable names

(cherry picked from commit 4b21fcf5)

authored Sep 18, 2018

49d2dd9e Browse Files

Remove lodash from tests (#1323) · a3bb5676
```
(cherry picked from commit d062352d)
```
Roman Exempliarov authored Sep 17, 2018
a3bb5676 Browse Files
Add unit test specific to Address utils (#1251) (#1316) · f8b0cec1
```
(cherry picked from commit 7825caa1)
```
Jakub Bogacz authored Sep 12, 2018
f8b0cec1 Browse Files
Update ERC20.sol (#1313) · 7ea34d9e
```
correct typo in doc

(cherry picked from commit b644c72e)
```
Jerome de Tychey authored Sep 10, 2018
7ea34d9e Browse Files
Fix README snippet typo · 2a8146a4
```
(cherry picked from commit 0b8296e5)
```
Francisco Giordano authored Sep 07, 2018
2a8146a4 Browse Files
fix readme snippet so it is concrete · 2e14386e
```
(cherry picked from commit 651f6d8b)
```
Francisco Giordano authored Sep 07, 2018
2e14386e Browse Files

18 Oct, 2018 6 commits

added a test helper with common constants (#1400) · 9f5b73df

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1206

(cherry picked from commit 58a42443)

authored Oct 10, 2018

9f5b73df Browse Files

Improves Ownable events (#1397) · a811a0be

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1392

* event tests added

* constructor event added

(cherry picked from commit af42c39e)

authored Oct 09, 2018

a811a0be Browse Files

Added a constructor to BreakInvariantBounty. (#1395) · 9c76d282
```
(cherry picked from commit 3acc2b42)
```
Nicolás Venturo authored Oct 08, 2018
9c76d282 Browse Files

Add Arrays library with unit tests (#1209) (#1375) · 8d6250cd

*     Add Arrays library with unit tests (#1209)

    * prepared due to snapshot token requirements
    * add library with method to find upper bound
    * add unit test for basic and edge cases

* Imporove documentation for Arrays library

Simplify Arrays.test.js to use short arrays as test date

* Added comment for uint256 mid variable.
* Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array.

(cherry picked from commit f7e53d90)

authored Oct 08, 2018

8d6250cd Browse Files

Removed selfdestruct from BreakInvariantBounty (#1385) · 66bad4ff

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1384

* introduced claimable and cancelBounty

* cancelBounty tests

* Update BreakInvariantBounty.test.js

(cherry picked from commit 41f84f8b)

authored Oct 08, 2018

66bad4ff Browse Files

Removed old, unused mocks. (#1382) · 41e74dd8
```
(cherry picked from commit b17de011)
```
Nicolás Venturo authored Oct 05, 2018
41e74dd8 Browse Files

04 Oct, 2018 6 commits

Release candidate v2.0.0-rc.3 · 2d309181
Nicolás Venturo authored Oct 04, 2018

2d309181 Browse Files
Removed unnecessary Secondary inheritance from RefundEscrow. (#1381) · 0db1f814
```
(cherry picked from commit 308e5e9c)
```
Nicolás Venturo authored Oct 04, 2018
0db1f814 Browse Files
ERC20 internal transfer method (#1370) · ffeae0d8
```
(cherry picked from commit 43ebb4fc)
```
Anton Bukov authored Oct 03, 2018
ffeae0d8 Browse Files

Removing unrequired `_burn()` override (#1373) · 38ca4221

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1371

* Removed extra whitespace

(cherry picked from commit f3888bb0)

authored Oct 03, 2018

38ca4221 Browse Files

Prevents Bounty from being claimed twice (#1374) · 7c984968

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1356

* Removed extra semicolon.

(cherry picked from commit c87433e0)

authored Oct 03, 2018

7c984968 Browse Files

Separate ERC721Mintable (#1365) · bd8345a1

* separate part of ERC721Mintable into ERC721MetadataMintable

* remove mint and burn from 721 tests

* Fixed linter error.

* fix ERC721 mint tests

* Minor fixes.

(cherry picked from commit 744f567f)

authored Oct 04, 2018

bd8345a1 Browse Files

28 Sep, 2018 3 commits

Fixed a broken payment test (+ another small fix) (#1318) · 76169cda

* Fixed a broken payment test

* In PR template, npm run lint:fix, not lint:all:fix

* In SplitPayment test, replaced an await-in-loop with Promise.all

(cherry picked from commit b79196f9)

authored Sep 11, 2018

76169cda Browse Files

Add missing tests to ECSDA (#1248) · 08bf6bbe

* fix: refactor sign.js and related tests

* fix: remove unused dep

* fix: update package.json correctly

* Add missing tests to ECRecovery

* fix lint

* Reorganize the tests

* Reuse signature

* fix static errors

* Apply suggestions by @frangion and @nventuro

* Remove only

* More suggestions

* Remove unnecessary max-len

* remove only

(cherry picked from commit 75c0a59b)

authored Sep 26, 2018

08bf6bbe Browse Files

Add SignatureBouncer test for when msg.data is too short (#1360) · 8c394de4

* add test for msg.data too short

* fix test to hit that branch

* Update SignatureBouncer.test.js

(cherry picked from commit 1a4e5346)

authored Sep 27, 2018

8c394de4 Browse Files