Skip to content

O
openzeppelin-contracts-upgradeable
Switch branch/tag
  1. 20 Nov, 2019 1 commit
  3. 19 Nov, 2019 2 commits
  5. 15 Nov, 2019 2 commits
  7. 13 Nov, 2019 1 commit
    • Update ReentrancyGuard for Istanbul Hard Fork (#1992) · 33047ffd 
      * Update ReentrancyGuard for Istanbul Hard Fork

Changes:
Added L37, `_guardCounter = 1;`

Rationale:
The planned _Istanbul Hard Fork_ will implement [EIP 2200](https://github.com/ethereum/EIPs/blob/e4d4ea348e06c54d0075c400dc7b72430d427ff1/EIPS/eip-2200.md), which implements "net gas metering" for `sstore` operations. If the final value of `_guardCounter` is unchanged relative to the original value of it, a gas refund will be applied and charges for changing the value of `_guardCounter` will effectively not exist. This ends up being cheaper than the current implementation ONLY AFTER Istanbul. Before Istanbul, the added line actually ends up costing more gas.

Note that if `_guardCounter` is `0` initially, the initial cost and subsequent refund will both be larger than if `_guardCounter` is `1` initially. Although in both cases, the net gas cost (`gasCost - gasRefund`) are equal, it's better in terms of cost to have both the gas cost and refund smaller, as there is some limit to the percentage of a gas refund that can actually be realized.

* Update CHANGELOG.md

Added note for change to ReentrancyGuard.sol

* Update ReentrancyGuard.sol

* Update CHANGELOG.md
      ericDeCourcy authored
  9. 12 Nov, 2019 1 commit
  11. 11 Nov, 2019 4 commits
  13. 08 Nov, 2019 2 commits
  15. 05 Nov, 2019 2 commits
  17. 01 Nov, 2019 2 commits
  19. 31 Oct, 2019 2 commits
  21. 30 Oct, 2019 2 commits
  23. 29 Oct, 2019 19 commits