Commits · 58a42443dfe57a2c0e161539d0b363e5ca7bf8d9 · 俞永鹏 / openzeppelin-contracts-upgradeable

09 Oct, 2018 2 commits

added a test helper with common constants (#1400) · 58a42443

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1206

authored Oct 10, 2018

58a42443 Browse Files

Improves Ownable events (#1397) · af42c39e

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1392

* event tests added

* constructor event added

authored Oct 09, 2018

af42c39e Browse Files

08 Oct, 2018 3 commits

Added a constructor to BreakInvariantBounty. (#1395) · 3acc2b42
Nicolás Venturo authored Oct 08, 2018

3acc2b42 Browse Files

Add Arrays library with unit tests (#1209) (#1375) · f7e53d90

*     Add Arrays library with unit tests (#1209)

    * prepared due to snapshot token requirements
    * add library with method to find upper bound
    * add unit test for basic and edge cases

* Imporove documentation for Arrays library

Simplify Arrays.test.js to use short arrays as test date

* Added comment for uint256 mid variable.
* Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array.

authored Oct 08, 2018

f7e53d90 Browse Files

Removed selfdestruct from BreakInvariantBounty (#1385) · 41f84f8b

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1384

* introduced claimable and cancelBounty

* cancelBounty tests

* Update BreakInvariantBounty.test.js

authored Oct 08, 2018

41f84f8b Browse Files

06 Oct, 2018 1 commit
- Removed old, unused mocks. (#1382) · b17de011
  Nicolás Venturo authored Oct 05, 2018
  
  b17de011 Browse Files
04 Oct, 2018 6 commits
- Removed unnecessary Secondary inheritance from RefundEscrow. (#1381) · 308e5e9c
  Nicolás Venturo authored Oct 04, 2018
  
  308e5e9c Browse Files
- Separate ERC721Mintable (#1365) · 744f567f
```
* separate part of ERC721Mintable into ERC721MetadataMintable

* remove mint and burn from 721 tests

* Fixed linter error.

* fix ERC721 mint tests

* Minor fixes.
```
  Francisco Giordano authored Oct 04, 2018
  744f567f Browse Files
- `this` is used in tests (#1380) · b41b125c
```
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1200

* suggested change
```
  Aniket authored Oct 04, 2018
  b41b125c Browse Files
- Replaces `amount` with `value` for consistency (#1378) · fd4de776
```
* fixes #1372

* done in ERC20Capped and ERC20Mintable
```
  Aniket authored Oct 04, 2018
  fd4de776 Browse Files
- Add note about compiling artifacts to releasing steps (#1377) · ace14d3a
```
* add note about compiling artifacts to release notes

* add explanation of truffle bug
```
  Francisco Giordano authored Oct 03, 2018
  ace14d3a Browse Files
- Update issue templates (#1376) · 5c228805
```
* Update issue templates

* improve pull request template

* remove previous issue template
```
  Francisco Giordano authored Oct 03, 2018
  5c228805 Browse Files
03 Oct, 2018 2 commits

Prevents Bounty from being claimed twice (#1374) · c87433e0

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1356

* Removed extra semicolon.

authored Oct 03, 2018

c87433e0 Browse Files

Removing unrequired `_burn()` override (#1373) · f3888bb0

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* updates

* fixes #1371

* Removed extra whitespace

authored Oct 03, 2018

f3888bb0 Browse Files

02 Oct, 2018 4 commits
- ERC20 internal transfer method (#1370) · 43ebb4fc
  Anton Bukov authored Oct 03, 2018
  
  43ebb4fc Browse Files
- Fixed test path. · f4d6f404
  Nicolás Venturo authored Oct 02, 2018
  
  f4d6f404 Browse Files
- Created test utils directory · 269981ee
  Nicolás Venturo authored Oct 02, 2018
  
  269981ee Browse Files
- Merged latestTime, increaseTime and duration into a time helper. (#1364) · 34bc709b
  Nicolás Venturo authored Oct 02, 2018
  
  34bc709b Browse Files
01 Oct, 2018 2 commits

Fix/#1355 test helper to check balance difference (#1368) · 6ae041bc

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* fixex #1355

* linting

* suggested changes

* Update BreakInvariantBounty.test.js

authored Oct 01, 2018

6ae041bc Browse Files

Fix #1358 Test helper to send funds (#1367) · fa1dfbd1

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776.

* fixes #1358

* linting done

* suggested changes

authored Oct 01, 2018

fa1dfbd1 Browse Files

29 Sep, 2018 1 commit
- Dangling commas are now required. (#1359) · a6889776
  Nicolás Venturo authored Sep 28, 2018
  
  a6889776 Browse Files
27 Sep, 2018 2 commits

Add SignatureBouncer test for when msg.data is too short (#1360) · 1a4e5346
```
* add test for msg.data too short

* fix test to hit that branch

* Update SignatureBouncer.test.js
```
Francisco Giordano authored Sep 27, 2018
1a4e5346 Browse Files

Feature/use expect event in test logs assertions #1232 (#1343) · 536262f2

* Add BigNumber support to expectEvent/inLogs (#1026)

* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js

* Refactor expectEvent.inLogs function to use simple value number check

* Introduced should.be.bignumber method to compare BigNumber values

* Use expectEvent to test logs (#1232)

* Removed trailing space

authored Sep 27, 2018

536262f2 Browse Files

26 Sep, 2018 7 commits

Add missing tests to ECSDA (#1248) · 75c0a59b

* fix: refactor sign.js and related tests

* fix: remove unused dep

* fix: update package.json correctly

* Add missing tests to ECRecovery

* fix lint

* Reorganize the tests

* Reuse signature

* fix static errors

* Apply suggestions by @frangion and @nventuro

* Remove only

* More suggestions

* Remove unnecessary max-len

* remove only

authored Sep 26, 2018

75c0a59b Browse Files

Add BigNumber support to expectEvent/inLogs (#1026) (#1338) · 947de54c

* Add BigNumber support to expectEvent/inLogs (#1026)

* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js

* Refactor expectEvent.inLogs function to use simple value number check

* Introduced should.be.bignumber method to compare BigNumber values

* Destructure transaction object to extract logs field

authored Sep 26, 2018

947de54c Browse Files

Improved bounty tests. (#1350) · ae109f69
```
* Improved bounty tests.

* Fixed linter errors.

* Addressed review comments.
```
Nicolás Venturo authored Sep 26, 2018
ae109f69 Browse Files

Removed mintingFinished. (#1351) · 5fdeaa81

* Removed mintingFinished from ERC20Mintable.

* Removed MintingFinished from ERC721Mintable.

* Removed MintingFinished event.

authored Sep 26, 2018

5fdeaa81 Browse Files

Removed assertions from Escrow and SplitPayment. (#1349) · db2e1d2c
Nicolás Venturo authored Sep 26, 2018

db2e1d2c Browse Files
Add the missing test for ERC721Holder (#1249) · 396680b8
```
* Add the missing test for ERC721Holder

* fix lint

* Move the holder test to a separate file
```
Leo Arias authored Sep 26, 2018
396680b8 Browse Files

Roles now emit events in construction and when renouncing. (#1329) · 21198bf1

* release candidate v2.0.0-rc.1

* fix linter error

(cherry picked from commit c12a1c68)

* Roles now emit events in construction and when renouncing.

authored Sep 26, 2018

21198bf1 Browse Files

19 Sep, 2018 1 commit
- Turn off blank-lines Solium rule (#1284) · 9b371046
```
* turn off blank-lines rule

* remove triple newlines
```
  Francisco Giordano authored Sep 19, 2018
  9b371046 Browse Files
18 Sep, 2018 2 commits

Changes to Counter (#1332) · 3e55408c

* rename Index.currentId to current

* use += operator for clarity

* rename Counter.Index to Counter.Counter

* move Counter to drafts

authored Sep 18, 2018

3e55408c Browse Files

Add Mock suffix to variable names #1172 (#1324) · 4b21fcf5
```
* Add Mock suffix to variable names #1172

* Add Impl suffix to variable names
```
Martín authored Sep 18, 2018
4b21fcf5 Browse Files

17 Sep, 2018 1 commit
- Remove lodash from tests (#1323) · d062352d
  Roman Exempliarov authored Sep 17, 2018
  
  d062352d Browse Files
13 Sep, 2018 1 commit
- Rename AutoIncrementing to Counter (#1307) · b4f87bb8
  Leo Arias authored Sep 13, 2018
  
  b4f87bb8 Browse Files
12 Sep, 2018 2 commits
- Fixed relative imports. (#1321) · 225b4921
  Nicolás Venturo authored Sep 12, 2018
  
  225b4921 Browse Files
- Add unit test specific to Address utils (#1251) (#1316) · 7825caa1
  Jakub Bogacz authored Sep 12, 2018
  
  7825caa1 Browse Files
11 Sep, 2018 2 commits
- Fixed a broken payment test (+ another small fix) (#1318) · b79196f9
```
* Fixed a broken payment test

* In PR template, npm run lint:fix, not lint:all:fix

* In SplitPayment test, replaced an await-in-loop with Promise.all
```
  dwardu authored Sep 11, 2018
  b79196f9 Browse Files
- update Math.sol path (#1319) · d8cbd555
  Guillaume authored Sep 11, 2018
  
  d8cbd555 Browse Files
10 Sep, 2018 1 commit
- Update ERC20.sol (#1313) · b644c72e
```
correct typo in doc
```
  Jerome de Tychey authored Sep 10, 2018
  b644c72e Browse Files